[Bf-committers] pixelblending.c issues

Heikki Orsila bf-committers@blender.org
Thu, 27 Mar 2003 00:54:53 +0200 (EET)


  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

---559023410-1400336162-1048719293=:22995
Content-Type: TEXT/PLAIN; charset=US-ASCII

Here's a patch for
blender/source/blender/render/intern/source/pixelblending.c.

Also located here:

	http://shd.ton.tut.fi/patches/blender/

It should correct a logical error (not fatal) and make the code shorter
and probably faster.

logical error was:
 if ((!(target[3] == 0)) || (target[3] == 255)) {
this should have been:
 if (!(target[3] == 0) || target[3] == 255)) {

it's probably faster because it saves 3 floating point divides, and some
floating point <> char conversions.

Thanks for Jeroen (#RoccoD) for pointing out this function.

Heikki Orsila			There has yet to be any innovation, new
heikki.orsila@ee.tut.fi		features or new capabilities out of the
http://ee.tut.fi/~heikki	Linux platform. - Steve Ballmer of Microsoft

---559023410-1400336162-1048719293=:22995
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="pixelblending.h.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.GSO.4.44.0303270054530.22995@ee.tut.fi>
Content-Description: 
Content-Disposition: attachment; filename="pixelblending.h.diff"

MTk0YzE5NA0KPCB2b2lkIGFwcGx5S2V5QWxwaGFDaGFyQ29sKGNoYXIqIHRh
cmdldCk7DQotLS0NCj4gdm9pZCBhcHBseUtleUFscGhhQ2hhckNvbCh1bnNp
Z25lZCBjaGFyICp0YXJnZXQpOw0K
---559023410-1400336162-1048719293=:22995
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="pixelblending.c.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.GSO.4.44.0303270054531.22995@ee.tut.fi>
Content-Description: 
Content-Disposition: attachment; filename="pixelblending.c.diff"

LS0tIHBpeGVsYmxlbmRpbmcub3JnLmMJVGh1IE1hciAyNyAwMDozOTo0NSAy
MDAzDQorKysgcGl4ZWxibGVuZGluZy5jCVRodSBNYXIgMjcgMDA6NTI6MjMg
MjAwMw0KQEAgLTc1LDM1ICs3NSwyMiBAQA0KICAgZXZlci4gU3RyYW5nZSB0
aGluZyBpcyB0aGF0IGNvbG91cnMga2VlcCBvdmVyZmxvd2luZy4uLg0KIA0K
ICovDQotdm9pZCBhcHBseUtleUFscGhhQ2hhckNvbChjaGFyKiB0YXJnZXQp
IHsNCiANCi0JaWYgKCghKHRhcmdldFszXSA9PSAwKSkNCi0JCXx8ICh0YXJn
ZXRbM10gPT0gMjU1KSkgew0KLQkJLyogZWxzZTogbm90aGluZyB0byBkbyAq
Lw0KLQkJLyogY2hlY2sgd2hldGhlciBkaXYtaW5nIGlzIGVub3VnaCAqLw0K
LQkJZmxvYXQgY2ZbNF07DQotCQljZlswXSA9IHRhcmdldFswXS90YXJnZXRb
M107DQotCQljZlsxXSA9IHRhcmdldFsxXS90YXJnZXRbM107DQotCQljZlsy
XSA9IHRhcmdldFsyXS90YXJnZXRbM107DQotCQlpZiAoKGNmWzBdIDw9IDEu
MCkgJiYgKGNmWzFdIDw9IDEuMCkgJiYgKGNmWzJdIDw9IDEuMCkpIHsNCi0J
CQkvKiBhbGwgY29sb3VycyByZW1haW4gcHJvcGVybHkgc2NhbGVkPyAqLw0K
LQkJCS8qIHNjYWxlIHRvIGFscGhhICovDQotCQkJY2ZbMF0gPSAoZmxvYXQp
IHRhcmdldFswXSAqICgyNTUuMC8gKGZsb2F0KXRhcmdldFszXSk7DQotCQkJ
Y2ZbMV0gPSAoZmxvYXQpIHRhcmdldFsxXSAqICgyNTUuMC8gKGZsb2F0KXRh
cmdldFszXSk7DQotCQkJY2ZbMl0gPSAoZmxvYXQpIHRhcmdldFsyXSAqICgy
NTUuMC8gKGZsb2F0KXRhcmdldFszXSk7DQotDQotCQkJLyogQ2xpcHBpbmcg
aXMgaW1wb3J0YW50LiAqLw0KLQkJCXRhcmdldFswXSA9IChjZlswXSA+IDI1
NS4wID8gMjU1IDogKGNoYXIpIGNmWzBdKTsNCi0JCQl0YXJnZXRbMV0gPSAo
Y2ZbMV0gPiAyNTUuMCA/IDI1NSA6IChjaGFyKSBjZlsxXSk7DQotCQkJdGFy
Z2V0WzJdID0gKGNmWzJdID4gMjU1LjAgPyAyNTUgOiAoY2hhcikgY2ZbMl0p
Ow0KLQkJCQ0KK3ZvaWQgYXBwbHlLZXlBbHBoYUNoYXJDb2wodW5zaWduZWQg
Y2hhciAqdGFyZ2V0KSB7DQorCWludCBpLCB4Ow0KKwl1bnNpZ25lZCBjaGFy
IGFscGhhID0gdGFyZ2V0WzNdOw0KKwlpZiAoIShhbHBoYSA9PSAwIHx8IGFs
cGhhID09IDI1NSkpIHsNCisJCWlmICh0YXJnZXRbMF0gPD0gYWxwaGEgJiYg
dGFyZ2V0WzFdIDw9IGFscGhhICYmIHRhcmdldFsyXSA8PSBhbHBoYSkgew0K
KwkJCWZvciAoaT0wOyBpPDM7IGkrKykgew0KKwkJCQl4ID0gKChpbnQpIHRh
cmdldFtpXSkgKiAyNTUgLyAoKGludCkgYWxwaGEpOw0KKwkJCQl0YXJnZXRb
aV0gPSAoeCA8PSAyNTUpID8geCA6IDI1NTsNCisJCQl9DQogCQl9IGVsc2Ug
ew0KIAkJCS8qIHNob3VsZG4ndCBoYXBwZW4hIHdlIHdlcmUgcHJlbXVsLCBy
ZW1lbWJlcj8gKi8NCi0vKiBzaG91bGQgZ28gdG8gZXJyb3IgaGFuZGxlcjog
CQkJcHJpbnRmKCJOb24tcHJlbXVsIGNvbG91ciBkZXRlY3RlZFxuIik7ICov
DQorCQkJZnByaW50ZihzdGRlcnIsICJhcHBsZUtleUFscGhhQ2hhckNvbCgp
OiBOb24tcHJlbXVsIGNvbG91ciBkZXRlY3RlZFxuIik7DQogCQl9DQogCX0N
Ci0NCi19IC8qIGVuZCBvZiB2b2lkIGFwcGx5S2V5QWxwaGFDaGFyQ29sKGNo
YXIqIHRhcmdldCkgKi8NCit9IC8qIGVuZCBvZiB2b2lkIGFwcGx5S2V5QWxw
aGFDaGFyQ29sKHVuc2lnbmVkIGNoYXIgKnRhcmdldCkgKi8NCiANCiAvKiAt
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tICovDQogDQo=
---559023410-1400336162-1048719293=:22995--