[Bf-committers] Windows + geforge = please test

Ton Roosendaal bf-committers@blender.org
Sat, 5 Jul 2003 13:21:49 +0200


Hi,

Timothy verified this patch as well, so I've committed it.

However, it really feels like a hack. So hopefully the Ghosters here  
will take a deeper look into this, some day. I've added a descriptive  
comment to the patch.

Thanks Jacques!

-Ton-


On Thursday, Jul 3, 2003, at 01:40 Europe/Amsterdam, Jacques Beaurain  
wrote:

> Hi,
>
> Here is my attempt at a more complete patch. Let me know if it is okay
> please.
>
> Cheers,
>
> Jacques
>
> -----Original Message-----
> From: bf-committers-admin@blender.org
> [mailto:bf-committers-admin@blender.org] On Behalf Of Ton Roosendaal
> Sent: July 2, 2003 9:53 AM
> To: bf-committers@blender.org
> Subject: Re: [Bf-committers] Windows + geforge = please test
>
>
> Hi,
>
> If it really works with just a glFlush before swapbuffers, would be a
> miracle!
> Thanks for sorting out, but the patch looks incomplete?
>
> -Ton-
>
>
> On Tuesday, Jul 1, 2003, at 23:49 Europe/Amsterdam,
> <jbeaurain@istop.com> wrote:
>
>> Hi Brian,
>>
>> Sorry, I guess I could have been a bit more specific on where I put
>> the call.
>> There is a patch attached.
>>
>> Cheers,
>>
>> Jacques
>>
>> PS: I also looked at the specs briefly, it looks like one would have
>> to detect
>> whether antialiasing is enabled using glIsEnabled(MULTISAMPLE_ARB) and
>
>> then
>> use special calls to query and choose pixelformats to do it properly
>> (wglGetPixelFormatAttrib*vARB?) but I don't know a whole lot about
>> these
>> things and I guess the fix I made works because all rendering pipes
>> have not
>> been flushed in antialiased mode before the call to SwapBuffers.
>>
>>
>> Brian Innes <brianinnes81@yahoo.co.uk> said:
>>
>>>
>>>> Hi,
>>>>
>>>> I tried a number of things as well without any success. I was
>>>> playing around
>>>> with the pixelformat and realised that if I remove the
>>>> PFD_DOUBLEBUFFER flag
>>>> it looks much better. This lead me to suspect that the problem was
>>>> related to
>>>> the buffer swapping. I turned the flag back on and put a call to
>>>> glFinish
>>>> before SwapBuffers which worked great for all antialiasing modes
>>>> except
>>>> Quincux on my NVidia GeForce4 Ti4200. I used screencaps to verify
>>>> that the
>>>> antialiasing was indeed active.
>>>
>>> Jacques, could you possibly share the code you added / modified?
>>>
>>> I found this on the web, a PDF file of NVIDIA OpenGL Extension
>>> Specifications:
>>>
>>> http://www.vis.rwth-aachen.de/nagy/tutorials/nvOpenGLspecs.pdf
>>>
>>> At 554 pages it is not exactly light weight reading, but it may shed
>
>>> some
>>> light on the issue.
>>>
>>> cheers
>>>
>>> --
>>> Brian
>>> _______________________________________________
>>> Bf-committers mailing list
>>> Bf-committers@blender.org
>>> http://www.blender.org/mailman/listinfo/bf-committers
>>>
>>
>>
>>
>> --   
>>
>>
>>
>> Index: ./intern/ghost/intern/GHOST_WindowWin32.cpp
>> ===================================================================
>> RCS file:
>> /cvsroot/bf-blender/blender/intern/ghost/intern/>
> GHOST_WindowWin32.cpp,v
>> retrieving revision 1.4
>> diff -r1.4 GHOST_WindowWin32.cpp
>> 350a351
>>> 	glFinish();
>>>
> ----------------------------------------------------------------------- 
> -
>
> --
> Ton Roosendaal  Blender Foundation ton@blender.org
> http://www.blender.org
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers@blender.org
> http://www.blender.org/mailman/listinfo/bf-committers
> <patch.diff>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton@blender.org  
http://www.blender.org