[Bf-committers] huh? KX_BlenderSceneConverter.cpp

[Ton Roosendaal]

Hi,

Ahh, Hos did it the right way already. :)

-Ton-

On Wednesday, Dec 31, 2003, at 12:16 Europe/Amsterdam, Ton Roosendaal  
wrote:

> Hi,
>
> Ouch, mistake! I should have removed that from the engine too... but I  
> never recompile the darn thing since it's not working... :P
>
> By default, 'pad' variables are meant to indicate padding, empty space  
> in structs. That it was used for a menu was quite bad... further it is  
> also (from Blender release perspective) not a relevant menu to have.
>
> I'll comment out the line in the engine too, and wait for Kester (or  
> who else will pick up engine development) to decide on what's the use  
> of this menu, now Solid is back. Or is this menu being used now?
>
> -Ton-
>
>
> On Tuesday, Dec 30, 2003, at 21:24 Europe/Amsterdam, Nathan Letwory  
> wrote:
>
>> After reading even more through the code etc. I found that in  
>> buttons_shading.c the button for gameengines was disabled due to the  
>> use of pad1. This very same padding variable pad1 is used in  
>> KX_BlenderSceneConverter.cpp in the function ConvertScene. Reenabling  
>> the code in buttons_shading.c with changing pad1 to ge (also in  
>> KX_BlenderSceneConverter.cpp) and adding it to DNA_world_types.h (int  
>> ge), together with a padding variable (int pad1) all compiles fine  
>> and the gameengine button is back. I thought this being so small a  
>> fix, no need for a patch file :)
>>
>> /Nathan
>>
>>
>> John K. Walton wrote:
>>
>>> so, this just broke on irix... i don't see anyone commit a change?
>>> ideas?
>>> Thanks!
>>>
>>>
>>>
>>> ====> gmake all in source/gameengine/Converter
>>> CC -c -n32 -mips3 -Xcpluscomm -LANG:std -DNDEBUG -n32 -mips3 -O2
>>> -OPT:Olimit=0 -woff 1001,1110,1201,1209,1355,1424,1681,3201
>>> -I/usr/include  
>>> -I/usr/demos/blender/../lib/irix-6.5-mips/string/include
>>> -I/usr/demos/blender/../lib/irix-6.5-mips/SoundSystem/include
>>> -I/usr/demos/blender/../lib/irix-6.5-mips/python/include/python2.2
>>> -I/usr/demos/blender/source/gameengine/Physics/Sumo/Fuzzics/include
>>> -I/usr/demos/blender/source/gameengine/Physics/Sumo/include
>>> -I/usr/demos/blender/../lib/irix-6.5-mips/moto/include  
>>> -I../../blender
>>> -I../../blender/imbuf -I../../blender/makesdna  
>>> -I../../blender/include
>>> -I../../blender/blenlib -I../../blender/blenkernel
>>> -I../../blender/render/extern/include
>>> -I/usr/demos/blender/../lib/irix-6.5-mips/guardedalloc/include
>>> -I../Expressions -I../Rasterizer -I../GameLogic -I../Ketsji
>>> -I../BlenderRoutines -I../SceneGraph -I../../kernel/gen_system
>>> -I../Rasterizer/RAS_OpenGLRasterizer -I../Network  
>>> -I../Ketsji/KXNetwork
>>> -I../Physics/common -I../Physics/Dummy -I../Physics/BlOde
>>> KX_BlenderSceneConverter.cpp -o
>>> /usr/demos/blender/obj/irix-6.5-mips/gameengine/blconverter/ 
>>> KX_BlenderSceneConverter.o
>>> cc-1132 CC: ERROR File = KX_BlenderSceneConverter.cpp, Line = 186
>>>  The class "World" has no member "pad1".
>>>
>>>                        switch (blenderscene->world->pad1)
>>>                                                     ^
>>>
>>> cc-1174 CC: WARNING File = KX_BlenderSceneConverter.cpp, Line = 181
>>>  The variable "i" was declared but never referenced.
>>>
>>>                int i=0;
>>>                    ^
>>>
>>> 1 error detected in the compilation of  
>>> "KX_BlenderSceneConverter.cpp".
>>> gmake[3]: ***
>>> [/usr/demos/blender/obj/irix-6.5-mips/gameengine/blconverter/ 
>>> KX_BlenderSceneConverter.o]
>>> Error 2
>>> gmake[2]: *** [all] Error 1
>>> gmake[1]: *** [all] Error 1
>>> gmake: *** [all] Error 1
>>>
>>>
>>> _______________________________________________
>>> Bf-committers mailing list
>>> Bf-committers@blender.org
>>> http://www.blender.org/mailman/listinfo/bf-committers
>>>
>>
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers@blender.org
>> http://www.blender.org/mailman/listinfo/bf-committers
>>
>>
> ----------------------------------------------------------------------- 
> ---
> Ton Roosendaal  Blender Foundation ton@blender.org  
> http://www.blender.org
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers@blender.org
> http://www.blender.org/mailman/listinfo/bf-committers
>
>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton@blender.org  
http://www.blender.org