[Bf-committers] Netscape nspr suggestion

Volker Mische bf-committers@blender.org
Sun, 10 Nov 2002 13:52:43 +0100


Hi!

> On my Debian system the default location
> for the mozilla nspr headers is in the
> directory:
> 
> /usr/include/mozilla-1.0.0/nspr

On my Gentoo it system the default location is
/usr/include/mozilla/nspr

 > [...]
> RCS file: 
> /cvs01/blender/source/gameengine/GamePlayer/netscape/src/Makefile,v
> retrieving revision 1.3
> diff -r1.3 Makefile
> 51a52
>  > CPPFLAGS += -I$(NAN_NSPR)/include/mozilla-1.0.0/nspr

I would propose
CPPFLAGS += -I$(NAN_NSPR)/nspr

> [...]
> RCS file: 
> /cvs01/blender/source/gameengine/GamePlayer/netscape/src/xpcom/Makefile,v
> retrieving revision 1.2
> diff -r1.2 Makefile
> 49a50,51
>  > CPPFLAGS += -I$(NAN_NSPR)/include/mozilla-1.0.0/nspr
>  > CPPFLAGS += -I$(NAN_MOZILLA)/include/mozilla-1.0.0/xpcom

and
CPPFLAGS += -I$(NAN_MOZILLA)/xpcom

>[...]


And another proposition: Perhaps there could be added a comment behind 
every NAN_* (in /source/nan_definitions.mk) which tells what paths will 
be added to the variable. This would make it easier to set them right.
(e.g. somethig like:
export NAN_PYTHON ?= $(LCGDIR)/python
	# $(NAN_PYTHON)/include/python$(NAN_PYTHON_VERSION)
export NAN_PYTHON_VERSION ?= 2.0 )


Cu,
   Volker Mische.