[Bf-committers] Netscape nspr suggestion

Chris Want bf-committers@blender.org
Fri, 08 Nov 2002 21:13:06 -0700


On my Debian system the default location
for the mozilla nspr headers is in the
directory:

/usr/include/mozilla-1.0.0/nspr

Unfortunately, this directory will
never be found by the Makefiles under
source/gameengine/GamePlayer/netscape,
which use:

CPPFLAGS += -I$(NAN_NSPR)/include
CPPFLAGS += -I$(NAN_NSPR)/include/nspr

Could somebody with commit acces apply
the following patches (provided they are
considered benign yet beneficial):

RCS file: 
/cvs01/blender/source/gameengine/GamePlayer/netscape/src/Makefile,v
retrieving revision 1.3
diff -r1.3 Makefile
51a52
 > CPPFLAGS += -I$(NAN_NSPR)/include/mozilla-1.0.0/nspr

RCS file: 
/cvs01/blender/source/gameengine/GamePlayer/netscape/src/ketsji/Makefile,v
retrieving revision 1.4
diff -r1.4 Makefile
53a54
 > CPPFLAGS += -I$(NAN_NSPR)/include/mozilla-1.0.0/nspr

RCS file: 
/cvs01/blender/source/gameengine/GamePlayer/netscape/src/xpcom/Makefile,v
retrieving revision 1.2
diff -r1.2 Makefile
49a50,51
 > CPPFLAGS += -I$(NAN_NSPR)/include/mozilla-1.0.0/nspr
 > CPPFLAGS += -I$(NAN_MOZILLA)/include/mozilla-1.0.0/xpcom

RCS file: 
/cvs01/blender/source/gameengine/GamePlayer/netscape/test/stub/Makefile,v
retrieving revision 1.3
diff -r1.3 Makefile
46a47
 > CPPFLAGS += -I$(NAN_NSPR)/include/mozilla-1.0.0/nspr

RCS file: 
/cvs01/blender/source/gameengine/GamePlayer/netscape/test/colorcycle/Makefile,v
retrieving revision 1.3
diff -r1.3 Makefile
47c47
<
---
 > CPPFLAGS += -I$(NAN_NSPR)/include/mozilla-1.0.0/nspr

RCS file: 
/cvs01/blender/source/gameengine/GamePlayer/netscape/test/gears/Makefile,v
retrieving revision 1.3
diff -r1.3 Makefile
46a47
 > CPPFLAGS += -I$(NAN_NSPR)/include/mozilla-1.0.0/nspr

RCS file: 
/cvs01/blender/source/gameengine/GamePlayer/netscape/test/threaded_gears/Makefile,v
retrieving revision 1.3
diff -r1.3 Makefile
47c47
<
---
 > CPPFLAGS += -I$(NAN_NSPR)/include/mozilla-1.0.0/nspr

As a final note, the Makefile in
source/gameengine/GamePlayer/netscape/src/xpcom
tries to find the nspr headers using the
NAN_MOZILLA variable instead of the NAN_NSPR
variable -- this seems sloppy. This Makefile
also doesn't try to find the xpcom headers.

Regards,
Chris