[Bf-codereview] Freestyle r54826 branch review (issue 7416049)

[ideasman42 at gmail.com]

Hi thanks for addressing most of these issues.

Freestyle code managing blender scene data (copying+freeing). I can
accept as being convenient even though this is something to be avoided
where possible.

But there is one area of this branch I can't really accept - and this is
the addition of flags in edges/faces, only for freestyle's use.

I just think it sets a bad precedent that integrating new systems adds
arbitrary data to mesh elements - when we may want to use these later
for more general purposes.
Further - this is what mesh customdata was added for.

So I'd propose freestyle have its own customdata layers for edges/faces.
This could be an int layer which simply uses flags, or a struct which
has arbitrary data for freestyle.

In the long run this is probably better since edges could have their own
non-uniform thickness.
You could have edges blend in/out, currently from what I can see they
either draw or not - which I assume could flicker in some cases.

https://codereview.appspot.com/7416049/