[Bf-codereview] Custom Nodes (issue 7099061)

brechtvanlommel at gmail.com brechtvanlommel at gmail.com
Tue Jan 22 16:31:44 CET 2013


https://codereview.appspot.com/7099061/diff/30005/doc/python_api/examples/bpy.types.NodeTree.1.py
File doc/python_api/examples/bpy.types.NodeTree.1.py (right):

https://codereview.appspot.com/7099061/diff/30005/doc/python_api/examples/bpy.types.NodeTree.1.py#newcode23
doc/python_api/examples/bpy.types.NodeTree.1.py:23: return
context.scene.render.engine == 'CYCLES'
The code snippet here is not an example of get_from_context

https://codereview.appspot.com/7099061/diff/30005/intern/cycles/blender/blender_shader.cpp
File intern/cycles/blender/blender_shader.cpp (right):

https://codereview.appspot.com/7099061/diff/30005/intern/cycles/blender/blender_shader.cpp#newcode172
intern/cycles/blender/blender_shader.cpp:172: * are subclasses of
another.
I don't see how that's a problem, I wouldn't use XXX in comments unless
something is broken and needs to be fixed.

https://codereview.appspot.com/7099061/diff/30005/intern/cycles/render/nodes.h
File intern/cycles/render/nodes.h (right):

https://codereview.appspot.com/7099061/diff/30005/intern/cycles/render/nodes.h#newcode197
intern/cycles/render/nodes.h:197: class GroupInputNode : public
ShaderNode {
These two class are not used, so can be removed?

https://codereview.appspot.com/7099061/diff/30005/release/scripts/startup/bl_ui/node.py
File release/scripts/startup/bl_ui/node.py (right):

https://codereview.appspot.com/7099061/diff/30005/release/scripts/startup/bl_ui/node.py#newcode23
release/scripts/startup/bl_ui/node.py:23:
Does this file have a purpose?

https://codereview.appspot.com/7099061/


More information about the Bf-codereview mailing list