[Bf-codereview] Freestyle r54826 branch review (issue 7416049)

[tamito.kajiyama at gmail.com]

Hi Campbell,

I just filed an updated patch set in the Patch Tracker.
http://projects.blender.org/tracker/index.php?func=detail&aid=34859&group_id=9&atid=127

Could you please take a look at the patch and apply it to the trunk if
the changes are considered okay?

Thank you,
T.K.


On 2013/04/03 01:02:08, kjym3 wrote:
> Dear Reviewers,

> On 2013/04/03 00:25:10, kjym3 wrote:
> >
> > - Freestyle-specific code was removed from getCCGDerivedMesh and
> > edge/face marks were reimplemented using CD_ORIGINDEX edge/poly
layers
> > in convertblender.c [r55683].  Revision 55683 contains fixes for
> > modifiers not properly setting CD_ORIGINDEX layer entries.  These
> > fixes will be proposed as a patch set for the trunk and removed from
> > the branch.

> Here is a diff for the trunk:

> http://www.pasteall.org/41011/diff

> Upon inclusion of these fixes in the trunk, the corresponding changes
> in the Freestyle branch will be deleted.  Any comments and suggestions
> about the proposed fixes are duly acknowledged.

https://codereview.appspot.com/7416049/