[Bf-codereview] Freestyle r54826 branch review (issue 7416049)

[tamito.kajiyama at gmail.com]

Dear Reviewers,

Thanks again for all the review comments.  Based on suggestions
through the comments as well as personal communications in the IRC, a
number of changes have been made to address all the required updates.
Here is a quick summary of changes:

- The me->cd_flag values ME_CDFLAG_FREESTYLE_EDGE and
ME_CDFLAG_FREESTYLE_FACE were simply removed [r55705].

- Freestyle-specific code was removed from getCCGDerivedMesh and
edge/face marks were reimplemented using CD_ORIGINDEX edge/poly layers
in convertblender.c [r55683].  Revision 55683 contains fixes for
modifiers not properly setting CD_ORIGINDEX layer entries.  These
fixes will be proposed as a patch set for the trunk and removed from
the branch.

- Copyright information in file headers was updated [r55680] (many
thanks to Campbell for the updates).

- Default line style parameters were updated as suggested [r55677].

- Absolute paths to external style module files were eliminated by
means of text datablocks.  Now style modules are stored within .blend
files. [r55741]


https://codereview.appspot.com/7416049/diff/1/source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp
File source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp
(right):

https://codereview.appspot.com/7416049/diff/1/source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp#newcode649
source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp:649:
{
On 2013/03/30 09:55:14, irieshinsuke wrote:
> I think the default line color should remain black (the factory
setting also
> should be black), because we usually use dark line color for cartoon
pictures.
> After the default line color was changed to white, I have to change
the line
> color every time I add a line set...

Fixed in revision 55677.

https://codereview.appspot.com/7416049/