[Bf-codereview] Use Bullet for convex hull (issue 6741063)

NicholasBishop at gmail.com NicholasBishop at gmail.com
Wed Oct 24 01:56:14 CEST 2012


Thanks for reviewing, committed as r51557 and r51558 with the scons
fixes.

On 2012/10/23 18:33:23, brechtvl wrote:
> Looks ok to me, also works well in some tests. If scons files are
updated too
> this LGTM.


https://codereview.appspot.com/6741063/diff/1/source/blender/editors/mesh/CMakeLists.txt
> File source/blender/editors/mesh/CMakeLists.txt (right):


https://codereview.appspot.com/6741063/diff/1/source/blender/editors/mesh/CMakeLists.txt#newcode77
> source/blender/editors/mesh/CMakeLists.txt:77:
add_definitions(-DUSE_BULLET)
> The convention is to use -DWITH_BULLET, although it looks like this is
already
> inconsistent elsewhere.

> More importantly though, this should be add to SConscript too in both
> editors/mesh/ and bmesh/.


https://codereview.appspot.com/6741063/


More information about the Bf-codereview mailing list