[Bf-codereview] Blender password text input (issue 6713044)

[brechtvanlommel at gmail.com]

https://codereview.appspot.com/6713044/diff/1/source/blender/editors/interface/interface_widgets.c
File source/blender/editors/interface/interface_widgets.c (right):

https://codereview.appspot.com/6713044/diff/1/source/blender/editors/interface/interface_widgets.c#newcode953
source/blender/editors/interface/interface_widgets.c:953: * \brief This
function convert password string that should not be displayed
The doxygen style for comments are not necessary, plain english is ok,
we don't really use that.

https://codereview.appspot.com/6713044/diff/1/source/blender/editors/interface/interface_widgets.c#newcode971
source/blender/editors/interface/interface_widgets.c:971: * black
circle, despite this character is in font file */
I looked in the bfont.ttf and can't find this character. I've mailed
Bastien who I understand has last updated the font file, probably it's
not very hard to add this character.

https://codereview.appspot.com/6713044/diff/1/source/blender/editors/interface/interface_widgets.c#newcode990
source/blender/editors/interface/interface_widgets.c:990: } else if
((drawstr[i] >> 5) == 6) {
This doesn't follow code style convention, } and else are supposed to be
on separate lines.

https://codereview.appspot.com/6713044/