[Bf-codereview] OSL Script Node (issue 6506102)

brechtvanlommel at gmail.com brechtvanlommel at gmail.com
Wed Oct 10 12:48:08 CEST 2012


https://codereview.appspot.com/6506102/diff/6002/source/blender/blenkernel/intern/text.c
File source/blender/blenkernel/intern/text.c (right):

https://codereview.appspot.com/6506102/diff/6002/source/blender/blenkernel/intern/text.c#newcode592
source/blender/blenkernel/intern/text.c:592: for (mat =
bmain->mat.first; mat; mat = mat->id.next) {
This doesn't check node groups?

https://codereview.appspot.com/6506102/diff/6002/source/blender/nodes/shader/node_shader_tree.c
File source/blender/nodes/shader/node_shader_tree.c (right):

https://codereview.appspot.com/6506102/diff/6002/source/blender/nodes/shader/node_shader_tree.c#newcode91
source/blender/nodes/shader/node_shader_tree.c:91: /*XXX ifdef with osl
*/
I guess this would not be needed if we make this a generic script node.

https://codereview.appspot.com/6506102/


More information about the Bf-codereview mailing list