[Bf-codereview] Frame node upgrade and general node editor tweaks (issue 6200062)

lukas.toenne at googlemail.com lukas.toenne at googlemail.com
Sat May 19 09:53:09 CEST 2012


On 2012/05/19 07:41:41, lukas.toenne wrote:

http://codereview.appspot.com/6200062/diff/4004/source/blender/windowmanager/intern/wm_event_system.c
> File source/blender/windowmanager/intern/wm_event_system.c (right):


http://codereview.appspot.com/6200062/diff/4004/source/blender/windowmanager/intern/wm_event_system.c#newcode2079
> source/blender/windowmanager/intern/wm_event_system.c:2079:
> ED_screen_set_subwinactive(C, event);
> Moving this function behind the screen area handlers allows it to
override any
> custom mouse cursors set by those handlers.

> This might possibly have side effects, but seems to work nicely at
first glance.

Forget about this one, it's not a good idea. The
ED_screen_set_subwinactive does a couple of things that are probably
needed by screen area handlers. Actually setting the mouse cursor might
be moved behind those handlers however.

http://codereview.appspot.com/6200062/


More information about the Bf-codereview mailing list