[Bf-codereview] Frame node upgrade and general node editor tweaks (issue 6200062)

lukas.toenne at googlemail.com lukas.toenne at googlemail.com
Thu May 10 13:21:44 CEST 2012


Reviewers: bf-codereview_blender.org,

Description:
A number of new features for the node editor in general and the Frame
node in particular.
For an detailed user-level description of new features see the following
blogpost:

http://code.blender.org/index.php/2012/05/node-editing-tweaks/

Known issues:

* The custom ui handler for mouse cursor feedback on border resize
overrides changes made by the generic ED_screen_set_subwinactive
function (called from wm_event_do_handlers). This means that approaching
an area border from within the node editor does not update the cursor to
the "move" cursor correctly:

   http://www.pasteall.org/pic/31569

   (It works when moving the other way, from 3D view to node editor
here). Advice on proper solution would be appreciated.

* The default selected/active theme colors for nodes (same as object
theme colors) should be set to the "Text Highlight" theme color for
consistency. Requires change to startup.blend, which blows up patch size
too much for codereview app, so will have to be done before trunk merge.

Please review this at http://codereview.appspot.com/6200062/

Affected files:
   release/scripts/presets/node_color/apricot.py
   release/scripts/presets/node_color/durian.py
   release/scripts/presets/node_color/mango.py
   release/scripts/presets/node_color/orange.py
   release/scripts/presets/node_color/peach.py
   release/scripts/startup/bl_operators/presets.py
   release/scripts/startup/bl_ui/space_node.py
   source/blender/blenkernel/BKE_node.h
   source/blender/blenkernel/intern/node.c
   source/blender/blenloader/intern/readfile.c
   source/blender/editors/include/ED_node.h
   source/blender/editors/interface/resources.c
   source/blender/editors/space_node/drawnode.c
   source/blender/editors/space_node/node_buttons.c
   source/blender/editors/space_node/node_draw.c
   source/blender/editors/space_node/node_edit.c
   source/blender/editors/space_node/node_intern.h
   source/blender/editors/space_node/node_ops.c
   source/blender/editors/space_node/node_select.c
   source/blender/editors/space_node/space_node.c
   source/blender/editors/transform/transform_conversions.c
   source/blender/editors/transform/transform_ops.c
   source/blender/makesdna/DNA_node_types.h
   source/blender/makesrna/intern/rna_nodetree.c
   source/blender/makesrna/intern/rna_userdef.c
   source/blender/nodes/intern/node_common.c




More information about the Bf-codereview mailing list