[Bf-codereview] BGE Harmony Branch (issue 5491068)
brechtvanlommel at gmail.com
brechtvanlommel at gmail.com
Mon Mar 5 16:46:53 CET 2012
https://codereview.appspot.com/5491068/diff/2001/source/blender/gpu/intern/gpu_extensions.c
File source/blender/gpu/intern/gpu_extensions.c (right):
https://codereview.appspot.com/5491068/diff/2001/source/blender/gpu/intern/gpu_extensions.c#newcode89
source/blender/gpu/intern/gpu_extensions.c:89: } GG = {1, 0, 0, 0, 0,
0};
Yes, shortening the line to {1, 0} is ok.
https://codereview.appspot.com/5491068/diff/2001/source/blender/gpu/intern/gpu_extensions.c#newcode873
source/blender/gpu/intern/gpu_extensions.c:873: GPUShader *blur_shader =
GPU_shader_get_builtin_shader(GPU_SHADER_SEP_GAUSSIAN_BLUR);
Printing something to the console is ok, it should already print the
glsl compile error too. Mainly it should not crash.
https://codereview.appspot.com/5491068/
More information about the Bf-codereview
mailing list