[Bf-codereview] Potential fix for bug #31880 (issue 6332047)

NicholasBishop at gmail.com NicholasBishop at gmail.com
Fri Jun 22 19:01:12 CEST 2012


On 2012/06/22 07:24:08, sergey.vfx wrote:
> Just sone more possible issue: when you join objects synchronization
of
> subdivision level happens in multiresModifier_prepare_join(). This
could have
> the same issue if you're joining objects with different multires
levels and
> which have got seevral instances.

> Apart from this - LGTM.

Good point about joining. Could be simply fixed by updating the level
for other instances, but I wonder if this is the right thing to do? From
the user perspective, it might seem a bit odd that joining two meshes
would modify other instances even though at the end of the join op the
instances aren't linked to the original input to the join op anymore.

Not sure how to simply fix it otherwise though, so adding patch with
just updating levels.

http://codereview.appspot.com/6332047/


More information about the Bf-codereview mailing list