[Bf-codereview] Particle Info node for Cycles (issue 6242069)

lukas.toenne at googlemail.com lukas.toenne at googlemail.com
Fri Jun 8 18:04:36 CEST 2012


http://codereview.appspot.com/6242069/diff/11001/intern/cycles/render/object.cpp
File intern/cycles/render/object.cpp (right):

http://codereview.appspot.com/6242069/diff/11001/intern/cycles/render/object.cpp#newcode150
intern/cycles/render/object.cpp:150: /* XXX why using OBJECT_SIZE for
flag texture as well? */
On 2012/06/08 15:24:24, brechtvl wrote:
> I guess this can be removed? Otherwise don't understand what this
question
> means.

I was a bit confused why you are using the OBJECT_SIZE for generating
the offset for the object_flag texture as well. If they actually use the
same amount of bytes per object that would be coincidence? But yeah,
shouldn't add random comments in code when i don't get it, too easy to
forget about them ...

http://codereview.appspot.com/6242069/


More information about the Bf-codereview mailing list