[Bf-codereview] Non-modal menus (issue 6279046)
brechtvanlommel at gmail.com
brechtvanlommel at gmail.com
Wed Jun 6 14:51:39 CEST 2012
http://codereview.appspot.com/6279046/diff/5001/source/blender/editors/interface/interface_handlers.c
File source/blender/editors/interface/interface_handlers.c (right):
http://codereview.appspot.com/6279046/diff/5001/source/blender/editors/interface/interface_handlers.c#newcode6562
source/blender/editors/interface/interface_handlers.c:6562:
ui_handle_button_event(C, event, but);
With this call to ui_handle_button_event the retval is ignored, but a
few lines later it is used? An event like a key press or mouse click
should only be handled exactly once, and that does not seem to be
assured here.
http://codereview.appspot.com/6279046/
More information about the Bf-codereview
mailing list