[Bf-codereview] Weight paint transfer (issue 6301100)

[ideasman42 at gmail.com]

http://codereview.appspot.com/6301100/diff/1/source/blender/editors/object/object_vgroup.c
File source/blender/editors/object/object_vgroup.c (right):

http://codereview.appspot.com/6301100/diff/1/source/blender/editors/object/object_vgroup.c#newcode379
source/blender/editors/object/object_vgroup.c:379:
with all these enums - would give a common prefix, WTx for eg (weight
transfer) --- if this was in its own file it wouldn't really matter so
much.

http://codereview.appspot.com/6301100/diff/1/source/blender/editors/object/object_vgroup.c#newcode381
source/blender/editors/object/object_vgroup.c:381:
REPLACE_ACTIVE_VERTEX_GROUP = 1,
also common prefix would be good for enums.

http://codereview.appspot.com/6301100/diff/1/source/blender/editors/object/object_vgroup.c#newcode434
source/blender/editors/object/object_vgroup.c:434: break;
to ensure error cases dont go unnoticed you can:

default:
   BLI_assert(0);
   break;

.... this goes for all switches here.

http://codereview.appspot.com/6301100/diff/1/source/blender/editors/object/object_vgroup.c#newcode549
source/blender/editors/object/object_vgroup.c:549: if(dw_src &&
dw_src->weight) {
is it possible that the 'dw_dst->weight' is NONZERO and it should be
copied in the case that dw_src->weight is 0? Looks like this is the case
to me.

http://codereview.appspot.com/6301100/diff/1/source/blender/editors/object/object_vgroup.c#newcode606
source/blender/editors/object/object_vgroup.c:606: dw_dst =
defvert_verify_index(*dv_dst, index_dst);
is it possible that the 'dw_dst->weight' is NONZERO and it should be
copied in the case that dw_src->weight is 0? Looks like this is the case
to me.

http://codereview.appspot.com/6301100/diff/1/source/blender/editors/object/object_vgroup.c#newcode659
source/blender/editors/object/object_vgroup.c:659: if(dw_src &&
dw_src->weight) {
is it possible that the 'dw_dst->weight' is NONZERO and it should be
copied in the case that dw_src->weight is 0?

Looks like this is the case to me.

http://codereview.appspot.com/6301100/