[Bf-codereview] Brightness/Contrast Node for Cycles (issue 5564044)

Daniel Salazar - 3Developer.com zanqdo at gmail.com
Mon Jan 23 03:32:02 CET 2012


Perfect! thanks for this

straight HDRi
http://www.pasteall.org/pic/show.php?id=24932

slightly contrasted HDRi
http://www.pasteall.org/pic/show.php?id=24933

Daniel Salazar
patazstudio.com



On Sun, Jan 22, 2012 at 8:21 PM,  <dfelinto at gmail.com> wrote:
> Reviewers: bf-codereview_blender.org, brechtvl,
>
> Description:
> Contrast helps to adjust IBL (HDR images used for background lighting).
>
> A question, should we call it Bright (as we are doing in composite) or
> Brightness in the UI? So far this patch is calling Bright.
>
> Please review this at http://codereview.appspot.com/5564044/
>
> Affected files:
>   intern/cycles/app/cycles_xml.cpp
>   intern/cycles/blender/blender_shader.cpp
>   intern/cycles/kernel/CMakeLists.txt
>   intern/cycles/kernel/osl/nodes/CMakeLists.txt
>   intern/cycles/kernel/osl/nodes/node_brightness.osl
>   intern/cycles/kernel/svm/svm.h
>   intern/cycles/kernel/svm/svm_brightness.h
>   intern/cycles/kernel/svm/svm_types.h
>   intern/cycles/render/nodes.cpp
>   intern/cycles/render/nodes.h
>   source/blender/blenkernel/BKE_node.h
>   source/blender/blenkernel/intern/node.c
>   source/blender/makesrna/intern/rna_nodetree_types.h
>   source/blender/nodes/CMakeLists.txt
>   source/blender/nodes/NOD_shader.h
>   source/blender/nodes/shader/nodes/node_shader_brightness.c
>   source/blender/nodes/shader/nodes/node_shader_gamma.c
>
>
> _______________________________________________
> Bf-codereview mailing list
> Bf-codereview at blender.org
> http://lists.blender.org/mailman/listinfo/bf-codereview


More information about the Bf-codereview mailing list