[Bf-codereview] Color Matte Node (issue 5530079)

[jbkkavt at gmail.com]

Hi Dalai,

some small remarks. The rest is ok!


http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/nodes/COM_ColorMatteNode.cpp
File source/blender/compositor/nodes/COM_ColorMatteNode.cpp (right):

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/nodes/COM_ColorMatteNode.cpp#newcode45
source/blender/compositor/nodes/COM_ColorMatteNode.cpp:45:
inputSocketKey->relinkConnections(operationRGBToHSV_Key->getInputSocket(0),
true, 0, graph);
inputSocketKey->relinkConnections(operationRGBToHSV_Key->getInputSocket(0),
true, 1, graph);

Should be '1' not '0'

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/operations/COM_ColorMatteOperation.cpp
File source/blender/compositor/operations/COM_ColorMatteOperation.cpp
(right):

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/operations/COM_ColorMatteOperation.cpp#newcode24
source/blender/compositor/operations/COM_ColorMatteOperation.cpp:24:
#include "COM_OutputSocket.h"
#include could be minimized.
Sorry is leftover of older situation

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/operations/COM_ColorMatteOperation.cpp#newcode54
source/blender/compositor/operations/COM_ColorMatteOperation.cpp:54:
float alpha;
Can't see where this is used

http://codereview.appspot.com/5530079/