[Bf-codereview] Simplification of node muting and new detach operator (issue 5695063)

[lukas.toenne at googlemail.com]

http://codereview.appspot.com/5695063/diff/1/source/blender/editors/transform/transform_ops.c
File source/blender/editors/transform/transform_ops.c (right):

http://codereview.appspot.com/5695063/diff/1/source/blender/editors/transform/transform_ops.c#newcode953
source/blender/editors/transform/transform_ops.c:953:
WM_keymap_add_item(keymap, "NODE_OT_move_detach_links", GKEY, KM_PRESS,
KM_ALT, 0);
On 2012/02/25 16:27:09, mont29 wrote:
> Alt-G is already taken by ungroup, had to change it to ctrl-alt-G…

Hmm yes, didn't think of that ... Even though ALT+G for ungroup is
established for a long time, the GKEY is more generally used for
translation. So if ALTKEY is supposed to be the modifier for detaching,
i'd rather have a different key combination for ungroup.

Hopefully ungroup will become much less necessary with the group node
changes as well, currently it seems mostly needed for extending a group
or for making another variant (ungroup + make new group). So maybe a new
key combination for it wouldn't be that bad.

http://codereview.appspot.com/5695063/diff/1/source/blender/gpu/GPU_material.h
File source/blender/gpu/GPU_material.h (right):

http://codereview.appspot.com/5695063/diff/1/source/blender/gpu/GPU_material.h#newcode118
source/blender/gpu/GPU_material.h:118: //int
GPU_stack_link_mute(GPUMaterial *mat, const char *name, struct
LinkInOutsMuteNode *mlnk);
On 2012/02/25 16:27:09, mont29 wrote:
> You can remove those funcs, imho. They were only added for shader
muting…

Done.

http://codereview.appspot.com/5695063/diff/1/source/blender/gpu/intern/gpu_codegen.c
File source/blender/gpu/intern/gpu_codegen.c (right):

http://codereview.appspot.com/5695063/diff/1/source/blender/gpu/intern/gpu_codegen.c#newcode1257
source/blender/gpu/intern/gpu_codegen.c:1257: #if 0
On 2012/02/25 16:27:09, mont29 wrote:
> To be removed too, imho; :)

> Also, you should remove the OpenGL shader code from
gpu_shader_material.gsl (the
> copy_raw() funcs) and regenerate gpu_shader_material.gsl.c file. I
think they
> are only used by current muting code.

Done.

http://codereview.appspot.com/5695063/