[Bf-codereview] Channel Matte Node (issue 5602051)

dfelinto at gmail.com dfelinto at gmail.com
Fri Feb 3 13:26:22 CET 2012


> 1. custom1 and custom2 are legacy, I would not like to have them in
tiles
That means I should leave as it's in the patch? or you have something
else in mind?

> 2. I prefer to use const int. but there are cases where it doesn't
work (M$ bug,
> just let DingTo help out there.)
Strange. I'll investigate.

> 3. it is ok how you implemented it. having two operations is the
second best
> option, third if the if-statement
I'm glad I did get the priority order right ;)


I will change the const to this-> and commit (after I nap and wake up)
Thanks Jeroen

http://codereview.appspot.com/5602051/


More information about the Bf-codereview mailing list