[Bf-codereview] Fisheye Panorama for Cycles (issue 6111052)
brechtvanlommel at gmail.com
brechtvanlommel at gmail.com
Fri Apr 27 12:29:53 CEST 2012
Looks good to commit, with these two small tweaks:
In collada/CameraExporter.cpp, it makes a bit more sense to export
panorama as perspective rather than ortho, since that's how it shows in
the viewport.
http://codereview.appspot.com/6111052/diff/12001/intern/cycles/kernel/kernel_montecarlo.h
File intern/cycles/kernel/kernel_montecarlo.h (right):
http://codereview.appspot.com/6111052/diff/12001/intern/cycles/kernel/kernel_montecarlo.h#newcode235
intern/cycles/kernel/kernel_montecarlo.h:235: float phi = acosf(u/r);
(0.5, 0.5) will give division by zero and so a NaN here, change to:
acosf((r != 0.0f)? u/r: 0.0f);
http://codereview.appspot.com/6111052/
More information about the Bf-codereview
mailing list