[Bf-codereview] Weight Paint (Radish Branch 2011) (issue 5021044)

[jason.hays22 at gmail.com]

On 2011/09/18 03:28:21, ideasman42 wrote:

http://codereview.appspot.com/5021044/diff/1/source/blender/editors/space_view3d/view3d_select.c
> File source/blender/editors/space_view3d/view3d_select.c (right):


http://codereview.appspot.com/5021044/diff/1/source/blender/editors/space_view3d/view3d_select.c#newcode206
> source/blender/editors/space_view3d/view3d_select.c:206: static void
> EM_backbuf_checkAndSelectTVerts(Mesh *me, int select)
> On 2011/09/17 22:48:38, jason.hays22 wrote:
> > On 2011/09/15 03:00:08, ideasman42 wrote:
> > > This functions confusingly prefixed EM_ which stands for EditMesh,
but this
> > > actually runs in object mode.
> > I was following the example of the face mask function
> > EM_backbuf_checkAndSelectTFaces()
> > Would you like me to change it anyway?

> ack, I see you're point.
> EM_backbuf_checkAndSelectTFaces is also wrong.

> committed r40313, and commented that this is wrong confusing, temp
name:
> EM_backbuf_checkAndSelectVerts_obmode


http://codereview.appspot.com/5021044/diff/1/source/blender/makesrna/intern/rna_object.c
> File source/blender/makesrna/intern/rna_object.c (right):


http://codereview.appspot.com/5021044/diff/1/source/blender/makesrna/intern/rna_object.c#newcode224
> source/blender/makesrna/intern/rna_object.c:224: void
> rna_update_active_object(Main *bmain, Scene *scene, PointerRNA *ptr)
> On 2011/09/17 19:17:37, jason.hays22 wrote:
> > On 2011/09/15 12:43:04, ideasman42 wrote:
> > > On 2011/09/15 07:57:10, nazgul wrote:
> > > > I've seen this function is used only once in rna_scene. Is it
really so
> > common
> > > > so it should be public?
> > >
> > > Its been removed now.
> > Hey, I had a reason for this.
> >
> > RNA_def_property_update(prop, NC_GEOM|ND_DATA, 0);
> > didn't work well enough in rna_scene because when Multi-Paint is
> > activated/deactivated, the colors will not change right away when
multiple
> bones
> > are selected.
> > The same thing occurs with auto normalize (while multi-paint is
active)
> >
> > What should I do as an alternative?

> Yep, I see this is a problem - Added this back under
> 'rna_Scene_update_active_object_data', with a note that this should
only be used
> in special cases and that it may be better as a notifier.

What about auto normalize?  It changes the way multi-paint draws the
weight colors, and if it is toggled without that update function, the
colors will not update immediately.

http://codereview.appspot.com/5021044/