[Bf-codereview] Console Scroll Down (issue 5036048)
ideasman42 at gmail.com
ideasman42 at gmail.com
Sat Sep 17 13:59:10 CEST 2011
Request this be moved into a static function rather than an operator
which is called by another.
http://codereview.appspot.com/5036048/diff/1/source/blender/editors/interface/view2d_ops.c
File source/blender/editors/interface/view2d_ops.c (right):
http://codereview.appspot.com/5036048/diff/1/source/blender/editors/interface/view2d_ops.c#newcode453
source/blender/editors/interface/view2d_ops.c:453:
RNA_def_boolean(ot->srna, "bottom", 0, "Bottom", "Scroll down to the
bottom");
Think adding this option is not the best place, IMHO this is console
specific. text has Ctrl+End which works ok
http://codereview.appspot.com/5036048/diff/1/source/blender/editors/space_console/console_ops.c
File source/blender/editors/space_console/console_ops.c (right):
http://codereview.appspot.com/5036048/diff/1/source/blender/editors/space_console/console_ops.c#newcode289
source/blender/editors/space_console/console_ops.c:289: PointerRNA ptr;
This operator should just set the view values directly, args can also be
space / area (data thats modified) rather then Context.
http://codereview.appspot.com/5036048/
More information about the Bf-codereview
mailing list