[Bf-codereview] Blender Cucumber to Trunk (issue 4961053)

dfelinto at gmail.com dfelinto at gmail.com
Tue Sep 13 19:54:14 CEST 2011


just noticed a big problem in the DNA changes.


http://codereview.appspot.com/4961053/diff/7001/source/blender/makesdna/DNA_scene_types.h
File source/blender/makesdna/DNA_scene_types.h (right):

http://codereview.appspot.com/4961053/diff/7001/source/blender/makesdna/DNA_scene_types.h#newcode443
source/blender/makesdna/DNA_scene_types.h:443: short mode, flag,
matmode;
Overall comment in the DNA:
you cannot do changes in the middle of the DNA struct (unless to replace
a pad by a real property).
I can explain why on irc if you want.

So the changes here need to be rearranged.

http://codereview.appspot.com/4961053/


More information about the Bf-codereview mailing list