[Bf-codereview] Camera tracking integration (issue 5285047)

[g.ulairi at gmail.com]

Hopefully i didn't missed some comments and included all patches into
new patchset.


http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/object.c
File source/blender/blenkernel/intern/object.c (right):

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/object.c#newcode2207
source/blender/blenkernel/intern/object.c:2207: if(ob->partype &
PARSLOW) {
Moved into function.

http://codereview.appspot.com/5285047/diff/26003/release/scripts/startup/bl_operators/clip.py
File release/scripts/startup/bl_operators/clip.py (right):

http://codereview.appspot.com/5285047/diff/26003/release/scripts/startup/bl_operators/clip.py#newcode49
release/scripts/startup/bl_operators/clip.py:49: if
bpy.data.objects[track.name].type == 'Empty':
Hrm, indeed. It'll be more clear to always create object. Removed this
matching.

http://codereview.appspot.com/5285047/diff/26003/release/scripts/startup/bl_ui/space_clip.py
File release/scripts/startup/bl_ui/space_clip.py (right):

http://codereview.appspot.com/5285047/diff/26003/release/scripts/startup/bl_ui/space_clip.py#newcode351
release/scripts/startup/bl_ui/space_clip.py:351: op =
row.operator("clip.camera_preset_add", text="", icon="ZOOMOUT")
I can't tel it's really normally called props. Can see plenty of places
where it's called op. Even more, can see some files mixed using op and
props =\
Changed to props in my file.

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_space.c
File source/blender/makesrna/intern/rna_space.c (right):

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_space.c#newcode856
source/blender/makesrna/intern/rna_space.c:856: static BGpic
*rna_BackgroundImage_add(View3D *v3d)
Wasn't sure which file is correct to add this function. Placed it into
view3d_edit.c

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c
File source/blender/makesrna/intern/rna_tracking.c (right):

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode259
source/blender/makesrna/intern/rna_tracking.c:259:
RNA_def_property_ui_text(prop, "Speed", "Speed to make tracking with");
It's nothing to do with quality, just for a visual feedback.

http://codereview.appspot.com/5285047/