[Bf-codereview] Camera sensor size (issue 5274047)

[ideasman42 at gmail.com]

patch looks good, would rename all references to width / x --> size,
some other comments inline.


http://codereview.appspot.com/5274047/diff/4001/source/blender/blenkernel/intern/object.c
File source/blender/blenkernel/intern/object.c (right):

http://codereview.appspot.com/5274047/diff/4001/source/blender/blenkernel/intern/object.c#newcode3021
source/blender/blenkernel/intern/object.c:3021: if(rd->xasp*winx >=
rd->yasp*winy)	viewfac= ((*lens) * winx) / (*sensor_x);
*picky* - looks like a sensor size rather than a sensor_x since it uses
maximum dimension, perhaps should be named sensor_size?

http://codereview.appspot.com/5274047/diff/4001/source/blender/modifiers/intern/MOD_uvproject.c
File source/blender/modifiers/intern/MOD_uvproject.c (right):

http://codereview.appspot.com/5274047/diff/4001/source/blender/modifiers/intern/MOD_uvproject.c#newcode171
source/blender/modifiers/intern/MOD_uvproject.c:171: sensor_x=
camera->sensor_x;
Dont think its correct to use the scene camera here, instead it should
use the sensor size from the camera referenced from the object and
fallback to 32 if its not a camera.

http://codereview.appspot.com/5274047/