[Bf-codereview] Blender Dynamic Paint (soc-2011-carrot) (issue 5189041)

[Miika Hämäläinen]

6.10.2011 16:35, g.ulairi at gmail.com wrote:
> Hi,
>
> Made really quick review, so just some of issues reported.
>
> General remarks:
> - You're checking for result of MEM_calloc function which i'm not sure
> really useful. Blender needs more general mechanism to survive memory
> shortage and that checks only made code a bit less easy to read and
> sometimes returning form middle of function lead to memory leaks.
Yes, I'm not sure if this is good practice at all. It certainly makes 
code harder to read and write...

Otherwise however, it would crash and I'm sure that's not good either. :p

> - I'm not sure making some structures from BVH public also necessary. I
> didn't see dynamic-paint structures used in that callbacks (probably
> just overview them).
This is clearly an issue in my code. I suppose there was need for that 
struct when I was experimenting with particle brush code, but I never 
noticed it was no more used when I finished.