[Bf-codereview] VIEWER: Add toggle to determine correct glBlendFunc with regards to associated or unassociated alpha (issue 5176042)

lukas.toenne at googlemail.com lukas.toenne at googlemail.com
Mon Oct 3 15:10:58 CEST 2011


Looks good for this purpose, only suggest that one rename.

 From a design perspective i'm not sure how this should work ideally.
Making the user select the alpha mode of the image sounds like a cheap
way out of the whole alpha premul mess. At least this could be stored
per image, so the user has to define that only once when loading an
image (reasonable default is another question then).


http://codereview.appspot.com/5176042/diff/1/source/blender/makesrna/intern/rna_space.c
File source/blender/makesrna/intern/rna_space.c (right):

http://codereview.appspot.com/5176042/diff/1/source/blender/makesrna/intern/rna_space.c#newcode1643
source/blender/makesrna/intern/rna_space.c:1643: prop=
RNA_def_property(srna, "draw_alpha", PROP_BOOLEAN, PROP_NONE);
The RNA property name should be more precise, i.e. draw_alpha_premul, to
avoid confusion with overall draw mode flags

http://codereview.appspot.com/5176042/


More information about the Bf-codereview mailing list