[Bf-codereview] Paths and Windows Installer Fixes (issue4529081)

[nathan.letwory at gmail.com]

Excuses for the earlier foobarring with portable install config/ testing
- was a mistake on my side (it works in trunk).

I have now annotated the parts that break the portable install ability.
These should be fixed, then IMO good to go.


http://codereview.appspot.com/4529081/diff/8003/source/blender/blenlib/intern/path_util.c
File source/blender/blenlib/intern/path_util.c (left):

http://codereview.appspot.com/4529081/diff/8003/source/blender/blenlib/intern/path_util.c#oldcode1029
source/blender/blenlib/intern/path_util.c:1029: if (get_path_local(path,
"datafiles", subfolder, ver)) break;
shouldn't be removed (portable installs)

http://codereview.appspot.com/4529081/diff/8003/source/blender/blenlib/intern/path_util.c#oldcode1039
source/blender/blenlib/intern/path_util.c:1039: if (get_path_local(path,
"autosave", subfolder, ver)) break;
shouldn't be removed (portable installs)

http://codereview.appspot.com/4529081/diff/8003/source/blender/blenlib/intern/path_util.c#oldcode1050
source/blender/blenlib/intern/path_util.c:1050: if (get_path_local(path,
"config", subfolder, ver)) break;
Shouldn't be removed (portable installs)

http://codereview.appspot.com/4529081/diff/8003/source/blender/blenlib/intern/path_util.c
File source/blender/blenlib/intern/path_util.c (right):

http://codereview.appspot.com/4529081/diff/8003/source/blender/blenlib/intern/path_util.c#newcode1043
source/blender/blenlib/intern/path_util.c:1043: if (get_path_user(path,
"datafiles", subfolder, "BLENDER_USER_DATAFILES", ver))	break;
This change and the next few changes regarding get_path_local shouldn't
be made. It's important we always check get_path_local first, otherwise
our ability to do portable installs will be broken.

http://codereview.appspot.com/4529081/diff/8003/source/blender/blenlib/intern/path_util.c#newcode1077
source/blender/blenlib/intern/path_util.c:1077: if (get_path_user(path,
"scripts", subfolder, "BLENDER_USER_SCRIPTS", ver)) break;
Still check get_path_local first, for portable installs.

http://codereview.appspot.com/4529081/