[Bf-codereview] Normals baker from sculpt data (issue4518055)

brechtvanlommel at gmail.com brechtvanlommel at gmail.com
Thu May 19 11:57:30 CEST 2011


LGTM, though would still change the name of the flat heights option.


http://codereview.appspot.com/4518055/diff/14014/source/blender/makesrna/intern/rna_scene.c
File source/blender/makesrna/intern/rna_scene.c (right):

http://codereview.appspot.com/4518055/diff/14014/source/blender/makesrna/intern/rna_scene.c#newcode2013
source/blender/makesrna/intern/rna_scene.c:2013: {RE_BAKE_SPEC_COLOR,
"SPEC_COLOR", 0, "Specular Colors", "Bake Specular colors"},
Looks like another patch got mixed in, probably harmless since this is
already in trunk.

http://codereview.appspot.com/4518055/diff/14014/source/blender/makesrna/intern/rna_scene.c#newcode2822
source/blender/makesrna/intern/rna_scene.c:2822:
RNA_def_property_ui_text(prop, "Flat Heights", "Calculate heights
against bare lo-res mesh");
Would change "bare lo-res mesh" to "unsubdivided low resolution mesh".
"Flat Heights" is still a weird name to me, how about "Bake to Low
Resolution"?

http://codereview.appspot.com/4518055/


More information about the Bf-codereview mailing list