[Bf-codereview] Node changes from Particles Branch (issue4476050)

[Lukas Tönne]

Alright, all the bugs you noted should be fixed now (plus two minor
issues i found myself).

Would be nice if you could take a quick look at the new naming scheme
i used for the nodes folder.
Node tree types are now one level below in the
composite/shader/texture folders, while the 'intern' folder contains
shared code.
The actual node files are now named like "node_composite_defocus.c".
Could be shortened to "node_cmp_defocus.c" (shd/tex respectively).


On Wed, May 11, 2011 at 7:28 PM,  <lukas.toenne at googlemail.com> wrote:
>
> http://codereview.appspot.com/4476050/diff/16001/source/blender/blenkernel/intern/node.c
> File source/blender/blenkernel/intern/node.c (right):
>
> http://codereview.appspot.com/4476050/diff/16001/source/blender/blenkernel/intern/node.c#newcode74
> source/blender/blenkernel/intern/node.c:74: #include
> "intern/node_socket.h"
> On 2011/05/10 16:06:25, brechtvl wrote:
>>
>> The functions used here should be in a public header for the nodes
>
> module, e.g.
>>
>> NOD_nodes.h, going into intern like that is not a good precedent.
>
> Done. The node tree types now have their own directory each. NOD is the
> primary prefix for all public node headers in the nodes directory.
>
> http://codereview.appspot.com/4476050/diff/16001/source/blender/blenkernel/intern/node.c#newcode1546
> source/blender/blenkernel/intern/node.c:1546: #if 0
> On 2011/05/10 16:06:25, brechtvl wrote:
>>
>> Seems this code can be removed.
>
> Done.
>
> http://codereview.appspot.com/4476050/
>