[Bf-codereview] Remesh modifier (dual contouring) (issue 5491053)

sergey.vfx at gmail.com sergey.vfx at gmail.com
Tue Dec 20 16:00:02 CET 2011


Hi,

Just two minor tihngs noted incomments. And one thing i'm not sure about
atm: it's related on usage of int64_t. Depending on order of includes,
it might give issues when building with msvc. Will compile this patch
tomorrow to doublecheck, so you might not worry about thi atm.


http://codereview.appspot.com/5491053/diff/19/intern/dualcon/CMakeLists.txt
File intern/dualcon/CMakeLists.txt (right):

http://codereview.appspot.com/5491053/diff/19/intern/dualcon/CMakeLists.txt#newcode1
intern/dualcon/CMakeLists.txt:1: # $Id$
Picky: we decided not to use $$Id keyword anymore

http://codereview.appspot.com/5491053/diff/19/intern/dualcon/intern/octree.h
File intern/dualcon/intern/octree.h (right):

http://codereview.appspot.com/5491053/diff/19/intern/dualcon/intern/octree.h#newcode101
intern/dualcon/intern/octree.h:101: const int edgevmap[12][2] =
{{0,4},{1,5},{2,6},{3,7},{0,2},{1,3},{4,6},{5,7},{0,1},{2,3},{4,5},{6,7}};
Still onfuses a bit with constants from Pojections.cpp

http://codereview.appspot.com/5491053/


More information about the Bf-codereview mailing list