[Bf-codereview] Normal Node for Cycles (issue 5440091)

[brechtvanlommel at gmail.com]

Some comments, if those are fixed, LGTM.


http://codereview.appspot.com/5440091/diff/5001/intern/cycles/kernel/osl/nodes/node_normal.osl
File intern/cycles/kernel/osl/nodes/node_normal.osl (right):

http://codereview.appspot.com/5440091/diff/5001/intern/cycles/kernel/osl/nodes/node_normal.osl#newcode27
intern/cycles/kernel/osl/nodes/node_normal.osl:27: direction =
normalize(Direction);
direction => Direction

http://codereview.appspot.com/5440091/diff/5001/intern/cycles/kernel/osl/nodes/node_normal.osl#newcode30
intern/cycles/kernel/osl/nodes/node_normal.osl:30: Dot = -dot(Direction,
NormalIn);
The dot product should not be negated, normals do not point inside in
cycles.

http://codereview.appspot.com/5440091/diff/5001/intern/cycles/kernel/svm/svm_normal.h
File intern/cycles/kernel/svm/svm_normal.h (right):

http://codereview.appspot.com/5440091/diff/5001/intern/cycles/kernel/svm/svm_normal.h#newcode38
intern/cycles/kernel/svm/svm_normal.h:38: stack_store_float(stack,
out_dot_offset, -dot(direction, normalize(normal)));
Same here, normal should not be negated.

http://codereview.appspot.com/5440091/diff/5001/intern/cycles/render/nodes.cpp
File intern/cycles/render/nodes.cpp (right):

http://codereview.appspot.com/5440091/diff/5001/intern/cycles/render/nodes.cpp#newcode743
intern/cycles/render/nodes.cpp:743: }
No, the code used seems ok.

http://codereview.appspot.com/5440091/