[Bf-codereview] Camera Data Node for Cycles (Blender) (issue 5437112)

[dfelinto at gmail.com]

final set of comments, waiting for your 'go'


http://codereview.appspot.com/5437112/diff/1/intern/cycles/kernel/svm/svm_camera.h
File intern/cycles/kernel/svm/svm_camera.h (right):

http://codereview.appspot.com/5437112/diff/1/intern/cycles/kernel/svm/svm_camera.h#newcode29
intern/cycles/kernel/svm/svm_camera.h:29: zdepth = abs(vector[2]);
with cycles z we don't even need abs/fabsf I believe. Not it's depth =
vector.z;
and fyi: abs was the reason for the banding, with fabs the z was smooth;
On 2011/12/02 14:25:33, brechtvl wrote:
> this should be changed to fabsf(vector.z)

http://codereview.appspot.com/5437112/diff/1/intern/cycles/kernel/svm/svm_camera.h#newcode33
intern/cycles/kernel/svm/svm_camera.h:33: stack_store_float3(stack,
out_vector, vector);
the final version is with cycles Z (not blender). it makes more sense
indeed. no wonder blender had to abs(z).

On 2011/12/02 14:25:33, brechtvl wrote:
> this should be normalize(vector), maybe that makes it the same?

> sd->I would be the same for a perspective camera on the first hit, but
not for
> further bounces, so it shouldn't be used.

http://codereview.appspot.com/5437112/