[Bf-codereview] Camera Data Node for Cycles (Blender) (issue 5437112)

[brechtvanlommel at gmail.com]

http://codereview.appspot.com/5437112/diff/1/intern/cycles/kernel/svm/svm_camera.h
File intern/cycles/kernel/svm/svm_camera.h (right):

http://codereview.appspot.com/5437112/diff/1/intern/cycles/kernel/svm/svm_camera.h#newcode29
intern/cycles/kernel/svm/svm_camera.h:29: zdepth = abs(vector[2]);
this should be changed to fabsf(vector.z)

http://codereview.appspot.com/5437112/diff/1/intern/cycles/kernel/svm/svm_camera.h#newcode30
intern/cycles/kernel/svm/svm_camera.h:30: distance =
sqrt(dot(vector,vector));
this can be replaced by len(vector)

http://codereview.appspot.com/5437112/diff/1/intern/cycles/kernel/svm/svm_camera.h#newcode33
intern/cycles/kernel/svm/svm_camera.h:33: stack_store_float3(stack,
out_vector, vector);
this should be normalize(vector), maybe that makes it the same?

sd->I would be the same for a perspective camera on the first hit, but
not for further bounces, so it shouldn't be used.

http://codereview.appspot.com/5437112/