[Bf-codereview] 2.5x blenderplayer (BGE) anti-aliasing & embedding (issue4431072)

[nathan.letwory at gmail.com]

The patch looks good as far as I'm concerned.


http://codereview.appspot.com/4431072/diff/1/intern/ghost/intern/GHOST_WindowWin32.cpp
File intern/ghost/intern/GHOST_WindowWin32.cpp (right):

http://codereview.appspot.com/4431072/diff/1/intern/ghost/intern/GHOST_WindowWin32.cpp#newcode714
intern/ghost/intern/GHOST_WindowWin32.cpp:714: while (iAttributes[17] >
0) {
iAttributes[17] looks very obscure. At least have a comment explaining
it, or better yet, a comment *and* a descriptive #define for 17

http://codereview.appspot.com/4431072/diff/1/intern/ghost/intern/GHOST_WindowWin32.cpp#newcode727
intern/ghost/intern/GHOST_WindowWin32.cpp:727: iAttributes[17] -= 1;
See the previous comment about iAttributes[17]

http://codereview.appspot.com/4431072/diff/1/source/gameengine/GamePlayer/ghost/GPG_Application.h
File source/gameengine/GamePlayer/ghost/GPG_Application.h (right):

http://codereview.appspot.com/4431072/diff/1/source/gameengine/GamePlayer/ghost/GPG_Application.h#newcode66
source/gameengine/GamePlayer/ghost/GPG_Application.h:66: const bool
stereoVisual, const int stereoMode, const GHOST_TUns16 samples=0);
I know there hasn't been much before here, but please, add doxygen style
docs in headers whenever you add something :)

http://codereview.appspot.com/4431072/