[Bf-codereview] View3D Dolly (issue4353051)
brechtvanlommel at gmail.com
brechtvanlommel at gmail.com
Fri Apr 15 14:08:50 CEST 2011
Except for one comment, LGTM.
http://codereview.appspot.com/4353051/diff/1/source/blender/editors/space_view3d/view3d_edit.c
File source/blender/editors/space_view3d/view3d_edit.c (right):
http://codereview.appspot.com/4353051/diff/1/source/blender/editors/space_view3d/view3d_edit.c#newcode1489
source/blender/editors/space_view3d/view3d_edit.c:1489: SWAP(int,
event->x, event->prevx);
Modifying the actual value in event seems problematic, it can be used
elsewhere after the operator is done executing. Could invert simply be a
parameter to viewdolly_apply instead, rather than doing the double
inversion?
http://codereview.appspot.com/4353051/
More information about the Bf-codereview
mailing list