[Bf-codereview] Radial control RNA update (issue4280080)

[brechtvanlommel at gmail.com]

On 2011/04/03 05:31:44, nicholasbishop wrote:
> A question about improving the brush texture-getter:
> > Another alternative would be to not go through RNA here at all, and
tie these
> > textures to ID blocks, and basically pass in the ID block as a
property, and
> > have a generic function to get a texture from them. I'd prefer that
> personally,
> > and it makes it possible to get rid of fairly complex RNA function
calling
> code
> > in the operator.

> Do you mean that a GL texture field should be added to the ID struct
itself?

If it doesn't go through RNA, the gl texture id could simply be stored
in the operator data and freed at the end.

The reason you added the RNA function as a property is to make it more
generic, but my impression is that this adds quite a bit of complexity,
without making things all that generic in practice. So if the datablock
is passed as a property, it could check if it's a brush, and if so use
the texture from that.

That's going against the purpose of this patch, to me it still seems
better, I can't really thing of a nice way to decouple this.


http://codereview.appspot.com/4280080/