[Bf-blender-cvs] [345dded146e] master: Revert "Geometry Nodes: hide group inputs with "Hide Value" enabled in modifier"

Jacques Lucke noreply at git.blender.org
Tue Jan 31 19:31:26 CET 2023


Commit: 345dded146e5f573f546d9b56d1d82e9e0bf2a54
Author: Jacques Lucke
Date:   Tue Jan 31 19:28:22 2023 +0100
Branches: master
https://developer.blender.org/rB345dded146e5f573f546d9b56d1d82e9e0bf2a54

Revert "Geometry Nodes: hide group inputs with "Hide Value" enabled in modifier"

This reverts commit 11a9578a1972db0a2d3f4e593d9b22598340825b.

Reverting this because there was a miscommunication between Simon and me. Shortly
before I committed the change, Simon noticed that there are cases when "Hide Value"
is checked to hide the value in a group node, but we still want to show the value
in the modifier.

===================================================================

M	source/blender/modifiers/intern/MOD_nodes.cc

===================================================================

diff --git a/source/blender/modifiers/intern/MOD_nodes.cc b/source/blender/modifiers/intern/MOD_nodes.cc
index 140eec20582..da623881548 100644
--- a/source/blender/modifiers/intern/MOD_nodes.cc
+++ b/source/blender/modifiers/intern/MOD_nodes.cc
@@ -1733,9 +1733,6 @@ static void panel_draw(const bContext *C, Panel *panel)
 
     int socket_index;
     LISTBASE_FOREACH_INDEX (bNodeSocket *, socket, &nmd->node_group->inputs, socket_index) {
-      if (socket->flag & SOCK_HIDE_VALUE) {
-        continue;
-      }
       draw_property_for_socket(*C, layout, nmd, &bmain_ptr, ptr, *socket, socket_index);
     }
   }



More information about the Bf-blender-cvs mailing list