[Bf-blender-cvs] [b2534fb8661] master: Fix: anonymous attribute output requested even though it's not used

Jacques Lucke noreply at git.blender.org
Sat Jan 28 14:56:50 CET 2023


Commit: b2534fb8661e4168207f2ebee70925b2d6f27421
Author: Jacques Lucke
Date:   Sat Jan 28 14:55:39 2023 +0100
Branches: master
https://developer.blender.org/rBb2534fb8661e4168207f2ebee70925b2d6f27421

Fix: anonymous attribute output requested even though it's not used

The code removed here was intended to be an optimization that
avoids creating an additional node to join multiple attribute sets.
However, that optimization did not work, because it did not take
into account whether the single attribute set is required or not.

===================================================================

M	source/blender/nodes/intern/geometry_nodes_lazy_function.cc

===================================================================

diff --git a/source/blender/nodes/intern/geometry_nodes_lazy_function.cc b/source/blender/nodes/intern/geometry_nodes_lazy_function.cc
index 64551249e29..4c8a67f81b3 100644
--- a/source/blender/nodes/intern/geometry_nodes_lazy_function.cc
+++ b/source/blender/nodes/intern/geometry_nodes_lazy_function.cc
@@ -2523,9 +2523,6 @@ struct GeometryNodesLazyFunctionGraphBuilder {
     if (attribute_set_sockets.is_empty()) {
       return nullptr;
     }
-    if (attribute_set_sockets.size() == 1) {
-      return attribute_set_sockets[0];
-    }
 
     Vector<lf::OutputSocket *, 16> key;
     key.extend(attribute_set_sockets);



More information about the Bf-blender-cvs mailing list