[Bf-blender-cvs] [9ad051140c1] master: Revert "Fix T71137: curve minimum twist producing wrong geometry"

Ray Molenkamp noreply at git.blender.org
Wed Jan 25 19:00:58 CET 2023


Commit: 9ad051140c102c76dbebe03d4a238b733034cfba
Author: Ray Molenkamp
Date:   Wed Jan 25 10:58:42 2023 -0700
Branches: master
https://developer.blender.org/rB9ad051140c102c76dbebe03d4a238b733034cfba

Revert "Fix T71137: curve minimum twist producing wrong geometry"

This reverts commit 36a82314a0f5de65b54f6d8343a2899ed4e37010.
as it has broken tests for the last day and a half, it likely just
needs a test file update, but we can't keep this failing longer
than it already has.

===================================================================

M	source/blender/blenkernel/intern/curve.cc

===================================================================

diff --git a/source/blender/blenkernel/intern/curve.cc b/source/blender/blenkernel/intern/curve.cc
index 51902169366..744ef0e8009 100644
--- a/source/blender/blenkernel/intern/curve.cc
+++ b/source/blender/blenkernel/intern/curve.cc
@@ -2260,7 +2260,7 @@ static void make_bevel_list_3D_minimum_twist(BevList *bl)
   nr = bl->nr;
   while (nr--) {
 
-    if (nr + 1 >= bl->nr) { /* First time, otherwise first point adjusts last. */
+    if (nr + 3 > bl->nr) { /* first time and second time, otherwise first point adjusts last */
       vec_to_quat(bevp1->quat, bevp1->dir, 5, 1);
     }
     else {



More information about the Bf-blender-cvs mailing list