[Bf-blender-cvs] [361ebe98d51] master: Draw: Workbench Next: Fix shadow culling after recent cleanup commit

Miguel Pozo noreply at git.blender.org
Tue Jan 24 20:53:04 CET 2023


Commit: 361ebe98d5147ea918335bce0347e19d10d7276b
Author: Miguel Pozo
Date:   Tue Jan 24 15:45:07 2023 +0100
Branches: master
https://developer.blender.org/rB361ebe98d5147ea918335bce0347e19d10d7276b

Draw: Workbench Next: Fix shadow culling after recent cleanup commit

79ba1a1ac82d854d840e98141b2458e4c7e2a7dd changed virtual function signatures so they didn't match their parents.

===================================================================

M	source/blender/draw/engines/workbench/workbench_private.hh
M	source/blender/draw/engines/workbench/workbench_shadow.cc

===================================================================

diff --git a/source/blender/draw/engines/workbench/workbench_private.hh b/source/blender/draw/engines/workbench/workbench_private.hh
index 94b609519d6..5d9de764d56 100644
--- a/source/blender/draw/engines/workbench/workbench_private.hh
+++ b/source/blender/draw/engines/workbench/workbench_private.hh
@@ -269,8 +269,10 @@ class ShadowPass {
     ShadowView();
 
    protected:
-    virtual void compute_visibility(ObjectBoundsBuf &bounds, uint resource_len);
-    virtual VisibilityBuf &get_visibility_buffer();
+    virtual void compute_visibility(ObjectBoundsBuf &bounds,
+                                    uint resource_len,
+                                    bool debug_freeze) override;
+    virtual VisibilityBuf &get_visibility_buffer() override;
   } view_ = {};
 
   bool enabled_;
diff --git a/source/blender/draw/engines/workbench/workbench_shadow.cc b/source/blender/draw/engines/workbench/workbench_shadow.cc
index e4a409f1457..d13d717832e 100644
--- a/source/blender/draw/engines/workbench/workbench_shadow.cc
+++ b/source/blender/draw/engines/workbench/workbench_shadow.cc
@@ -202,8 +202,12 @@ void ShadowPass::ShadowView::set_mode(ShadowPass::PassType type)
   current_pass_type_ = type;
 }
 
-void ShadowPass::ShadowView::compute_visibility(ObjectBoundsBuf &bounds, uint resource_len)
+void ShadowPass::ShadowView::compute_visibility(ObjectBoundsBuf &bounds,
+                                                uint resource_len,
+                                                bool debug_freeze)
 {
+  UNUSED_VARS(debug_freeze);
+
   GPU_debug_group_begin("ShadowView.compute_visibility");
 
   uint word_per_draw = this->visibility_word_per_draw();



More information about the Bf-blender-cvs mailing list