[Bf-blender-cvs] [2bbabbc7396] blender-v3.3-release: Fix T102801: Empty metasequence sliding away while moving

Richard Antalik noreply at git.blender.org
Thu Jan 12 15:31:54 CET 2023


Commit: 2bbabbc7396669f926b2a476f91ccac96613cf47
Author: Richard Antalik
Date:   Mon Nov 28 18:23:29 2022 +0100
Branches: blender-v3.3-release
https://developer.blender.org/rB2bbabbc7396669f926b2a476f91ccac96613cf47

Fix T102801: Empty metasequence sliding away while moving

Meta strip position relies on strips within. When meta strip is empty,
update function, that would normally update it's position returns early
and this causes translaton to behave erratically.

When strip is empty, treat it as normal strip and move its start frame
as with other strip types.

===================================================================

M	source/blender/sequencer/intern/strip_transform.c

===================================================================

diff --git a/source/blender/sequencer/intern/strip_transform.c b/source/blender/sequencer/intern/strip_transform.c
index 447ab9c221d..5e2e9244c50 100644
--- a/source/blender/sequencer/intern/strip_transform.c
+++ b/source/blender/sequencer/intern/strip_transform.c
@@ -138,9 +138,10 @@ void SEQ_transform_translate_sequence(Scene *evil_scene, Sequence *seq, int delt
     return;
   }
 
-  /* Meta strips requires special handling: their content is to be translated, and then frame range
-   * of the meta is to be updated for the updated content. */
-  if (seq->type == SEQ_TYPE_META) {
+  /* Meta strips requires their content is to be translated, and then frame range of the meta is
+   * updated based on nested strips. Thiw won't work for empty metas, so they can be treated as
+   * normal strip. */
+  if (seq->type == SEQ_TYPE_META && !BLI_listbase_is_empty(&seq->seqbase)) {
     Sequence *seq_child;
     for (seq_child = seq->seqbase.first; seq_child; seq_child = seq_child->next) {
       SEQ_transform_translate_sequence(evil_scene, seq_child, delta);



More information about the Bf-blender-cvs mailing list