[Bf-blender-cvs] [15b36dc4e61] blender-v3.3-release: Fix: greasepencil selection of entire_strokes not working

Philipp Oeser noreply at git.blender.org
Thu Jan 12 14:07:18 CET 2023


Commit: 15b36dc4e61a44444fbbde701f4aae1f9c46c42e
Author: Philipp Oeser
Date:   Tue Nov 22 13:09:41 2022 +0100
Branches: blender-v3.3-release
https://developer.blender.org/rB15b36dc4e61a44444fbbde701f4aae1f9c46c42e

Fix: greasepencil selection of entire_strokes not working

Caused by rB85f90ed6fd88.

Above commit made sure whole strokes are selected when the
GP_SELECTMODE_STROKE is used in different modes, but ignored the fact
that this can also already be set by the entire_strokes select operator
property.

This is now corrected.

Differential Revision: https://developer.blender.org/D16576

===================================================================

M	source/blender/editors/gpencil/gpencil_select.c

===================================================================

diff --git a/source/blender/editors/gpencil/gpencil_select.c b/source/blender/editors/gpencil/gpencil_select.c
index 6d8f62ca57f..300cac996b9 100644
--- a/source/blender/editors/gpencil/gpencil_select.c
+++ b/source/blender/editors/gpencil/gpencil_select.c
@@ -2440,15 +2440,15 @@ static int gpencil_select_exec(bContext *C, wmOperator *op)
 
   /* if select mode is stroke, use whole stroke */
   if ((ob) && (ob->mode == OB_MODE_SCULPT_GPENCIL)) {
-    whole = (bool)(gpencil_select_mode_from_sculpt(ts->gpencil_selectmode_sculpt) ==
+    whole |= (bool)(gpencil_select_mode_from_sculpt(ts->gpencil_selectmode_sculpt) ==
                    GP_SELECTMODE_STROKE);
   }
   else if ((ob) && (ob->mode == OB_MODE_VERTEX_GPENCIL)) {
-    whole = (bool)(gpencil_select_mode_from_vertex(ts->gpencil_selectmode_sculpt) ==
+    whole |= (bool)(gpencil_select_mode_from_vertex(ts->gpencil_selectmode_sculpt) ==
                    GP_SELECTMODE_STROKE);
   }
   else {
-    whole = (bool)(ts->gpencil_selectmode_edit == GP_SELECTMODE_STROKE);
+    whole |= (bool)(ts->gpencil_selectmode_edit == GP_SELECTMODE_STROKE);
   }
 
   if (is_curve_edit) {



More information about the Bf-blender-cvs mailing list