[Bf-blender-cvs] [f32939af53a] blender-v3.3-release: Fix T101402: EEVEE: Wrong Volume transforms

Miguel Pozo noreply at git.blender.org
Thu Jan 12 14:07:17 CET 2023


Commit: f32939af53a110365a7563e9a43cba6423f8e94a
Author: Miguel Pozo
Date:   Fri Nov 25 12:43:30 2022 +0100
Branches: blender-v3.3-release
https://developer.blender.org/rBf32939af53a110365a7563e9a43cba6423f8e94a

Fix T101402: EEVEE: Wrong Volume transforms

Ensure VolumeUniformPool uses is always incremented when retrieving a buffer in alloc().
Otherwise the same buffer will be retrieved for more than one object when incrementing the pool size.

Reviewed By: fclem

Maniphest Tasks: T101402

Differential Revision: https://developer.blender.org/D16607

===================================================================

M	source/blender/draw/intern/draw_volume.cc

===================================================================

diff --git a/source/blender/draw/intern/draw_volume.cc b/source/blender/draw/intern/draw_volume.cc
index 8f4383a98d8..38a4a6f214a 100644
--- a/source/blender/draw/intern/draw_volume.cc
+++ b/source/blender/draw/intern/draw_volume.cc
@@ -56,7 +56,6 @@ struct VolumeUniformBufPool {
     if (used >= ubos.size()) {
       VolumeInfosBuf *buf = new VolumeInfosBuf();
       ubos.append(buf);
-      return buf;
     }
     return ubos[used++];
   }



More information about the Bf-blender-cvs mailing list