[Bf-blender-cvs] [302cb349c7f] master: Cleanup: quiet compiler warning

Jacques Lucke noreply at git.blender.org
Fri Jan 6 18:04:50 CET 2023


Commit: 302cb349c7f26446de3422e55c5972339ad65930
Author: Jacques Lucke
Date:   Fri Jan 6 18:04:41 2023 +0100
Branches: master
https://developer.blender.org/rB302cb349c7f26446de3422e55c5972339ad65930

Cleanup: quiet compiler warning

For some reason this resulted in a unused-variable warning (on gcc).
Think we had such false positives before when `constexpr` was used.

===================================================================

M	source/blender/blenlib/BLI_math_matrix.hh

===================================================================

diff --git a/source/blender/blenlib/BLI_math_matrix.hh b/source/blender/blenlib/BLI_math_matrix.hh
index a2d5abdc58b..a2884d04225 100644
--- a/source/blender/blenlib/BLI_math_matrix.hh
+++ b/source/blender/blenlib/BLI_math_matrix.hh
@@ -508,7 +508,7 @@ template<typename T, int NumCol, int NumRow, typename VectorT>
   using MatT = MatBase<T, NumCol, NumRow>;
   BLI_STATIC_ASSERT(VectorT::type_length <= MatT::col_len - 1,
                     "Translation should be at least 1 column less than the matrix.");
-  static constexpr int location_col = MatT::col_len - 1;
+  constexpr int location_col = MatT::col_len - 1;
   /* Avoid multiplying the last row if it exists.
    * Allows using non square matrices like float3x2 and saves computation. */
   using IntermediateVecT =



More information about the Bf-blender-cvs mailing list