[Bf-blender-cvs] [8fa7bcb59a4] refactor-mesh-sharp-edge-generic: Fix bad BMesh Mesh conversion logic

Hans Goudey noreply at git.blender.org
Thu Jan 5 04:18:25 CET 2023


Commit: 8fa7bcb59a4f0d39f247c18e073b4989f98a1af2
Author: Hans Goudey
Date:   Wed Jan 4 22:18:05 2023 -0500
Branches: refactor-mesh-sharp-edge-generic
https://developer.blender.org/rB8fa7bcb59a4f0d39f247c18e073b4989f98a1af2

Fix bad BMesh Mesh conversion logic

===================================================================

M	source/blender/bmesh/intern/bmesh_mesh_convert.cc

===================================================================

diff --git a/source/blender/bmesh/intern/bmesh_mesh_convert.cc b/source/blender/bmesh/intern/bmesh_mesh_convert.cc
index e05bbda11d3..b1c60df2706 100644
--- a/source/blender/bmesh/intern/bmesh_mesh_convert.cc
+++ b/source/blender/bmesh/intern/bmesh_mesh_convert.cc
@@ -358,7 +358,7 @@ void BM_mesh_bm_from_me(BMesh *bm, const Mesh *me, const struct BMeshFromMeshPar
     if (select_edge && select_edge[i]) {
       BM_edge_select_set(bm, e, true);
     }
-    if (!sharp_edges || !sharp_edges[i]) {
+    if (!(sharp_edges && sharp_edges[i])) {
       BM_elem_flag_enable(e, BM_ELEM_SMOOTH);
     }
 
@@ -1086,7 +1086,7 @@ void BM_mesh_bm_to_me(Main *bmain, BMesh *bm, Mesh *me, const struct BMeshToMesh
     BM_mesh_elem_table_ensure(bm, BM_EDGE);
     write_fn_to_attribute<bool>(
         me->attributes_for_write(), ".sharp_edge", ATTR_DOMAIN_EDGE, [&](const int i) {
-          return !BM_elem_flag_test(BM_edge_at_index(bm, i), BM_ELEM_SELECT);
+          return !BM_elem_flag_test(BM_edge_at_index(bm, i), BM_ELEM_SMOOTH);
         });
   }



More information about the Bf-blender-cvs mailing list